Skip to content

feat: allow RecordBatchWriter to pass through pass-through-commit-properties #3858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2025
Merged

feat: allow RecordBatchWriter to pass through pass-through-commit-properties #3858

merged 2 commits into from
Oct 16, 2025

Conversation

@rtyler
Copy link
Member

@rtyler rtyler commented Oct 16, 2025

I have seen some production use-cases which need to disable log cleanup
or other per-commit tweaks.

@rtyler
feat: allow RecordBatchWriter to pass through pass-through-commit-pro…
070249a 
…perties

I have seen some production use-cases which need to disable log cleanup
or other per-commit tweaks.

Signed-off-by: R. Tyler Croy <[email protected]>
@rtyler rtyler requested a review from hntd187 October 16, 2025 13:08
@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Oct 16, 2025
@codecov
Copy link

codecov bot commented Oct 16, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 65.11628% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.75%. Comparing base (3b6395b) to head (a8ac63b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/kernel/transaction/mod.rs 0.00% 6 Missing ⚠️
crates/core/src/writer/record_batch.rs 16.66% 5 Missing ⚠️
crates/core/src/writer/mod.rs 87.09% 0 Missing and 4 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3858      +/-   ##
==========================================
- Coverage   73.76%   73.75%   -0.02%     
==========================================
  Files         151      151              
  Lines       39139    39154      +15     
  Branches    39139    39154      +15     
==========================================
+ Hits        28872    28879       +7     
- Misses       8995     9003       +8     
  Partials     1272     1272

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rtyler rtyler marked this pull request as ready for review October 16, 2025 13:23
@rtyler rtyler requested a review from roeap as a code owner October 16, 2025 13:23
@rtyler rtyler enabled auto-merge (rebase) October 16, 2025 13:23
@rtyler rtyler merged commit daa8a68 into delta-io:main Oct 16, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ion-elgreco ion-elgreco ion-elgreco approved these changes

@hntd187 hntd187 Awaiting requested review from hntd187 hntd187 is a code owner

@roeap roeap Awaiting requested review from roeap roeap is a code owner

Assignees

No one assigned

Labels

binding/rust Issues for the Rust crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rtyler @ion-elgreco